Skip to content

Add dockerfile and instructions#1215

Closed
d4v3y0rk wants to merge 3 commits intogchq:masterfrom
d4v3y0rk:add-dockerfile
Closed

Add dockerfile and instructions#1215
d4v3y0rk wants to merge 3 commits intogchq:masterfrom
d4v3y0rk:add-dockerfile

Conversation

@d4v3y0rk
Copy link
Copy Markdown

This adds a working dockerfile to the project and instructions on how to use it in the readme.

(This could also be used to generate a docker image that can be pushed to Dockerhub for people to use if the project team so desires)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 20, 2021

CLA assistant check
All committers have signed the CLA.

@d4v3y0rk
Copy link
Copy Markdown
Author

@GCHQ77703 Just pinging to make sure this doesn't get forgotten about or fall too far down the list.

@oscrx
Copy link
Copy Markdown

oscrx commented Aug 10, 2021

I would suggest adding a staged build for a leaner container.

Also building with dockerx and releasing for multiple architectures (amd64, arm64, etc.)
Would be a nice feature, required for Raspberry pi's, M1 Apple devices (Docker for mac doesn't support Rosetta 2 yet), etc.
An example within a Github actions pipeline

Publishing to Github container repository (ghcr.io) is very easy and can be done with only the Github token already available in the Github actions pipeline. (see example above)

For docker hub; credentials need to be manually added by a project admin.

I might do a PR on your repo if I have the time tonight, if that is even possible.

@d4v3y0rk
Copy link
Copy Markdown
Author

I would suggest adding a staged build for a leaner container.

Also building with dockerx and releasing for multiple architectures (amd64, arm64, etc.)
Would be a nice feature, required for Raspberry pi's, M1 Apple devices (Docker for mac doesn't support Rosetta 2 yet), etc.
An example within a Github actions pipeline

Publishing to Github container repository (ghcr.io) is very easy and can be done with only the Github token already available in the Github actions pipeline. (see example above)

For docker hub; credentials need to be manually added by a project admin.

I might do a PR on your repo if I have the time tonight, if that is even possible.

all that would be great to add. if they would come back around and merge this we could add on some of those features later. Iterate.

@nileshtrivedi
Copy link
Copy Markdown

This would be really helpful for easier deployment in container environments (like CapRover for self-hosting).

@d4v3y0rk
Copy link
Copy Markdown
Author

d4v3y0rk commented Nov 27, 2021 via email

@lnodaba
Copy link
Copy Markdown

lnodaba commented Jul 1, 2022

This doesn't build. I get this error:
image

CC: @d4v3y0rk

@gary-sixgen
Copy link
Copy Markdown

👀

@a3957273
Copy link
Copy Markdown
Member

Supplanted by #1699

@a3957273 a3957273 closed this Feb 22, 2024
@a3957273
Copy link
Copy Markdown
Member

Docker images are now automatically built and provided here: https://github.com/gchq/CyberChef/pkgs/container/cyberchef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants