Set the system timer resolution to the minimum value for higher precision on Windows#907
Merged
GiulioRomualdi merged 3 commits intomasterfrom Oct 30, 2024
Merged
Set the system timer resolution to the minimum value for higher precision on Windows#907GiulioRomualdi merged 3 commits intomasterfrom
GiulioRomualdi merged 3 commits intomasterfrom
Conversation
traversaro
approved these changes
Oct 30, 2024
Collaborator
Author
|
I need to add the following line in the cmake. However given how the cmake machinery is implemented I need to modify the cmake functions if(WIN32)
target_link_libraries(iFeelDriver PRIVATE Winmm)
endif() |
S-Dafarra
approved these changes
Oct 30, 2024
Collaborator
Author
Fixed in d5c9801 |
Collaborator
Just as a general comment, an alternative is to also define a add_bipedal_locomotion_library(
NAME System
PUBLIC_HEADERS ${H_PREFIX}/InputPort.h ${H_PREFIX}/OutputPort.h
${H_PREFIX}/Advanceable.h ${H_PREFIX}/Source.h ${H_PREFIX}/Sink.h
${H_PREFIX}/Factory.h
${H_PREFIX}/VariablesHandler.h ${H_PREFIX}/LinearTask.h ${H_PREFIX}/ILinearTaskSolver.h ${H_PREFIX}/ILinearTaskFactory.h ${H_PREFIX}/ITaskControllerManager.h
${H_PREFIX}/IClock.h ${H_PREFIX}/StdClock.h ${H_PREFIX}/Clock.h
${H_PREFIX}/SharedResource.h ${H_PREFIX}/AdvanceableRunner.h
${H_PREFIX}/QuitHandler.h
${H_PREFIX}/Barrier.h ${H_PREFIX}/TimeProfiler.h
${H_PREFIX}/WeightProvider.h ${H_PREFIX}/ConstantWeightProvider.h
SOURCES src/VariablesHandler.cpp src/LinearTask.cpp
src/StdClock.cpp src/Clock.cpp src/QuitHandler.cpp src/Barrier.cpp
src/ConstantWeightProvider.cpp src/TimeProfiler.cpp
PUBLIC_LINK_LIBRARIES BipedalLocomotion::ParametersHandler Eigen3::Eigen
SUBDIRECTORIES tests YarpImplementation RosImplementation
OUTPUT_TARGET_NAME_VARIABLE BLF_SYSTEM_TARGET_NAME)
if(WIN32)
target_link_libraries(${BLF_SYSTEM_TARGET_NAME} PRIVATE Winmm)
endif()to avoid adding a specfical handling the the function whenever you need to do something specific to a target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.