USD -> SDF transform fixes#924
Merged
ahcorde merged 3 commits intoahcorde/usd_to_sdf_transformsfrom Mar 31, 2022
Merged
Conversation
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## ahcorde/usd_to_sdf_transforms #924 +/- ##
=================================================================
- Coverage 87.72% 87.72% -0.01%
=================================================================
Files 102 102
Lines 14939 14906 -33
=================================================================
- Hits 13105 13076 -29
+ Misses 1834 1830 -4
Continue to review full report at Codecov.
|
ahcorde
requested changes
Mar 31, 2022
Collaborator
ahcorde
left a comment
There was a problem hiding this comment.
This PR is breaking some transformations, the gripper is in the wrong rotation
ahcorde
requested changes
Mar 31, 2022
Collaborator
ahcorde
left a comment
There was a problem hiding this comment.
the order in the multiplication of the rotations is important, we can'nt create just a rotation.
I suggest you to add a TODO in the other PR and try to improve this code when everything is merge and it's easy to test.
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Here are some proposals I have after reviewing #871:
XandZrotation angles if the rotation is defined asRotationZYXinstead ofRotationXYZThe following changes simplify the API for the
UsdTransformsclass. Now, we no longer need methods for determining whether a rotation exists and if its XYZ/ZYX.I have also added a test case that uses the new
nested_transforms_ZYXprim defined intest/usd/nested_transforms.usda. Without swapping theXandZrotation angles for this prim, the test fails.Checklist
codecheckpassed (See contributing)