Skip to content

USD to SDF: Added some world plugins#901

Merged
ahcorde merged 7 commits intosdf12from
ahcorde/usd_to_sdf/plugins
Mar 23, 2022
Merged

USD to SDF: Added some world plugins#901
ahcorde merged 7 commits intosdf12from
ahcorde/usd_to_sdf/plugins

Conversation

@ahcorde
Copy link
Copy Markdown
Collaborator

@ahcorde ahcorde commented Mar 22, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

USD to SDF: Added some world plugins

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the usd label Mar 22, 2022
@ahcorde ahcorde requested a review from adlarkin March 22, 2022 19:05
@ahcorde ahcorde requested review from azeey and scpeters as code owners March 22, 2022 19:05
@ahcorde ahcorde self-assigned this Mar 22, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 22, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #901 (df8d898) into sdf12 (425985f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head df8d898 differs from pull request most recent head e2a45e4. Consider uploading reports for the commit e2a45e4 to get more accurate results

@@            Coverage Diff             @@
##            sdf12     #901      +/-   ##
==========================================
+ Coverage   88.11%   88.12%   +0.01%     
==========================================
  Files         100      100              
  Lines       14651    14668      +17     
==========================================
+ Hits        12909    12926      +17     
  Misses       1742     1742              
Impacted Files Coverage Δ
usd/src/usd_parser/USDWorld.cc 80.43% <100.00%> (+10.43%) ⬆️
usd/src/sdf_parser/Link.cc 61.84% <0.00%> (ø)
usd/src/UsdTestUtils.hh 99.00% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425985f...e2a45e4. Read the comment docs.

Comment thread usd/src/usd_parser/USDWorld.cc Outdated
Comment thread usd/src/usd_parser/usd2sdf_TEST.cc Outdated
ahcorde and others added 4 commits March 23, 2022 13:12
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@ahcorde ahcorde merged commit e5698ad into sdf12 Mar 23, 2022
@ahcorde ahcorde deleted the ahcorde/usd_to_sdf/plugins branch March 23, 2022 18:41
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress usd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants