Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
… ahcorde/usd_to_sdf_transforms
Signed-off-by: ahcorde <ahcorde@gmail.com>
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <ahcorde@gmail.com>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <ahcorde@gmail.com>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…hcorde/usd_to_sdf_visuals
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
… ahcorde/usd_to_sdf_collisions
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
adlarkin
reviewed
Apr 11, 2022
Contributor
adlarkin
left a comment
There was a problem hiding this comment.
Code LGTM, I left a few minor comments below. Would you mind adding tests?
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Collaborator
Author
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
adlarkin
approved these changes
Apr 12, 2022
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## sdf12 #898 +/- ##
==========================================
- Coverage 86.73% 86.57% -0.16%
==========================================
Files 106 108 +2
Lines 15450 15528 +78
==========================================
+ Hits 13401 13444 +43
- Misses 2049 2084 +35
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Added collisions to USD -> SDF converter
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.