USD to SDF: Apply rigid body to Model not to Link#889
Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## sdf12 #889 +/- ##
==========================================
- Coverage 88.16% 88.15% -0.01%
==========================================
Files 100 100
Lines 14637 14636 -1
==========================================
- Hits 12904 12903 -1
Misses 1733 1733
Continue to review full report at Codecov.
|
Collaborator
Author
|
@osrf-jenkins retest this please |
adlarkin
reviewed
Mar 22, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
adlarkin
approved these changes
Mar 23, 2022
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Applied rigid body to Model not to Link. Without this fix the link will update the position and not the model generating wrong behaviour in Issac Sim Physics
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.