Merged
Conversation
Each component has its own Export.hh header file and its own visibility macros, so use the proper visibility macros in the USD component. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
ahcorde
approved these changes
Feb 10, 2022
adlarkin
reviewed
Feb 10, 2022
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## sdf12 #849 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 78 78
Lines 12535 12535
=======================================
Hits 11378 11378
Misses 1157 1157 Continue to review full report at Codecov.
|
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes visibility macros in USD component. Part of #845.
Summary
Each ign-cmake component has its own Export.hh header file and its own visibility macros, so use the proper visibility macros in the header files of the USD component.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.