sdf -> usd Parse links and ground planes#828
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## sdf12 #828 +/- ##
=======================================
Coverage 90.80% 90.80%
=======================================
Files 78 78
Lines 12555 12555
=======================================
Hits 11400 11400
Misses 1155 1155 Continue to review full report at Codecov.
|
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
adlarkin
left a comment
There was a problem hiding this comment.
LGTM, but we should probably wait to merge this until the other PRs that depend on it (for example, joints) are created. I say this because we are introducing a new API for parsing a model, and once we merge this, we cannot update the model API since that would break API. So, let's make sure that the APIs proposed here don't cause issues with other parts of model parsing before doing any merging.
Signed-off-by: ahcorde <ahcorde@gmail.com>
…rapped sdf errors Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
adlarkin
left a comment
There was a problem hiding this comment.
LGTM! I am going to review the other PRs that require this one (#829, #830, #831) before giving this PR official approval to make sure that we don't need to modify the public API introduced in this PR for any of the other dependent PRs.
Also, it would be nice if we can get #850 reviewed and merged before merging this PR, because if we do decide to merge #850, then a few internal API calls made in this PR will need to be updated.
I have merged in #850 and resolved conflicts in f816dd4. I will now work on getting #829, #830, and #831 updated/reviewed. |
|
@adlarkin CI is working again |
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
This PR parse SDF up to links and convert it to USD
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.