looks like a compilation error with ign-math7

looks like a compilation error with ign-math7

It builds for me locally with gazebosim/gz-math#342, but the CI error seemed different. Let's see this new round.

there are test failures related to -0 in quaternion streams

there are test failures related to -0 in quaternion streams

I believe this is a behavior change with ign-math7 from gazebosim/gz-math#206

It builds for me locally with gazebosim/gz-math#342, but the CI error seemed different. Let's see this new round.

Humm it still fails on Ubuntu CI, with both Bionic and Focal

2021-12-27T19:15:10.4098630Z In file included from /github/workspace/src/Ellipsoid.cc:18:
2021-12-27T19:15:10.4099822Z /github/workspace/include/sdf/Ellipsoid.hh:20:10: fatal error: ignition/math/Ellipsoid.hh: No such file or directory
2021-12-27T19:15:10.4100715Z  #include <ignition/math/Ellipsoid.hh>
2021-12-27T19:15:10.4101593Z           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

It builds for me locally with ignitionrobotics/ign-math#342, but the CI error seemed different. Let's see this new round.

Humm it still fails on Ubuntu CI, with both Bionic and Focal

2021-12-27T19:15:10.4098630Z In file included from /github/workspace/src/Ellipsoid.cc:18:
2021-12-27T19:15:10.4099822Z /github/workspace/include/sdf/Ellipsoid.hh:20:10: fatal error: ignition/math/Ellipsoid.hh: No such file or directory
2021-12-27T19:15:10.4100715Z  #include <ignition/math/Ellipsoid.hh>
2021-12-27T19:15:10.4101593Z           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

I think that build started before the nightlies were rebuilt

This PR now builds on top of #805

Now we need gazebosim/gz-math#235 merged forward, CC @scpeters

/home/chapulina/dev_focal/ws_garden/src/sdformat/src/World.cc: In member function _sdf::v13::ElementPtr sdf::v13::World::ToElement() const_:
/home/chapulina/dev_focal/ws_garden/src/sdformat/src/World.cc:836:55: error: cannot convert _ignition::math::v7::SphericalCoordinates::Surfa
ceType_ to _const string&_ {aka _const std::__cxx11::basic_string<char>&_}
  836 |           this->dataPtr->sphericalCoordinates->Surface()));
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                       |
      |                                                       ignition::math::v7::SphericalCoordinates::SurfaceType

Now we need ignitionrobotics/ign-math#235 merged forward, CC @scpeters

/home/chapulina/dev_focal/ws_garden/src/sdformat/src/World.cc: In member function _sdf::v13::ElementPtr sdf::v13::World::ToElement() const_:
/home/chapulina/dev_focal/ws_garden/src/sdformat/src/World.cc:836:55: error: cannot convert _ignition::math::v7::SphericalCoordinates::Surfa
ceType_ to _const string&_ {aka _const std::__cxx11::basic_string<char>&_}
  836 |           this->dataPtr->sphericalCoordinates->Surface()));
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                       |
      |                                                       ignition::math::v7::SphericalCoordinates::SurfaceType

gazebosim/gz-math#344

Codecov Report

Merging #803 (71d8181) into main (4a7d129) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   90.70%   90.69%   -0.01%     
==========================================
  Files          78       78              
  Lines       12439    12440       +1     
==========================================
  Hits        11283    11283              
- Misses       1156     1157       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7d129...71d8181. Read the comment docs.