Decrease light intensities#801
Merged
ahcorde merged 1 commit intoadlarkin/sdf_to_usdfrom Dec 24, 2021
Merged
Conversation
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
ahcorde
approved these changes
Dec 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashton Larkin 42042756+adlarkin@users.noreply.github.com
🦟 Bug fix
Summary
@ahcorde here's a PR that decreases light intensities in USD, since they were too strong before. Feel free to modify the values used in this PR based on the test results you see in isaac sim. Right now, I set the directional light intensity to 1000 (it was 50000 by default), and all other light intensities to be scaled by 100 w.r.t. the SDF value.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.