Skip to content

Added tutorial to move an articulated arms#798

Merged
ahcorde merged 3 commits intoadlarkin/sdf_to_usdfrom
ahcorde/sdf_to_usd/arms_tutorial
Jan 6, 2022
Merged

Added tutorial to move an articulated arms#798
ahcorde merged 3 commits intoadlarkin/sdf_to_usdfrom
ahcorde/sdf_to_usd/arms_tutorial

Conversation

@ahcorde
Copy link
Copy Markdown
Collaborator

@ahcorde ahcorde commented Dec 22, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added a tutorial to convert a SDF model to USD (downloaded from fuel). There are two ways to move the arm:

  • Python script
  • Moveit

Maybe this is not the right place to locate tutorials, open to suggestions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from adlarkin December 22, 2021 20:53
@ahcorde ahcorde self-assigned this Dec 22, 2021
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@chapulina chapulina added the 🌱 garden Ignition Garden label Dec 30, 2021
@ahcorde ahcorde requested a review from adlarkin January 5, 2022 10:42
Copy link
Copy Markdown
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this locally yet, but the tutorial looks pretty good and reads well. I will try to test this locally later this week.

Comment thread tutorials/sdf_to_usd_arms.md
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Comment thread tutorials/sdf_to_usd_arms.md Outdated
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from adlarkin January 5, 2022 19:26
Copy link
Copy Markdown
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is not the right place to locate tutorials, open to suggestions

I think what you did (adding a tutorials folder) is fine. We can stick with this approach for now and move the location later if needed.


The tutorial looks good to me! I haven't tested it yet, but if you want/need to merge it now, feel free to do so.

@ahcorde ahcorde marked this pull request as ready for review January 6, 2022 14:52
@ahcorde ahcorde requested review from azeey and scpeters as code owners January 6, 2022 14:52
@ahcorde ahcorde merged commit 9b36de1 into adlarkin/sdf_to_usd Jan 6, 2022
@ahcorde ahcorde deleted the ahcorde/sdf_to_usd/arms_tutorial branch January 6, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants