Add unit tests for converting SDF to USD#796
Closed
adlarkin wants to merge 2 commits intoadlarkin/sdf_to_usdfrom
Closed
Add unit tests for converting SDF to USD#796adlarkin wants to merge 2 commits intoadlarkin/sdf_to_usdfrom
adlarkin wants to merge 2 commits intoadlarkin/sdf_to_usdfrom
Conversation
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
koonpeng
reviewed
Jan 3, 2022
koonpeng
left a comment
There was a problem hiding this comment.
usd has a known bug PixarAnimationStudios/OpenUSD#86 which causes it to exit the process cleanly if there is a fatal error. This can cause ci to stop early and report success if the program ever "crashes".
I can think of some workarounds
- fix upstream
- make all tests death tests, this is an ugly workaround which forks the process for every tests, the googletest docs mentions issues with forks which need to be worked around as well http://google.github.io/googletest/advanced.html#death-tests-and-threads.
- make a custom test runner which either captures and check stdout of the tests, or have each test write some artifacts and have the runner check them at the end.
This was referenced Jan 7, 2022
Contributor
Author
|
I am going to close this PR since the testing done here has been moved to #818, but I realize that we probably still need to address #796 (review) at some point. I have made a separate issue for this so that it can be discussed and worked on there: https://github.com/ignitionrobotics/sdformat/issues/826 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashton Larkin 42042756+adlarkin@users.noreply.github.com
🎉 New feature
Summary
Adding unit tests for converting things like lights and models from SDF to USD.
Test it
You can build SDF and run the
UNIT_sdf_usd_TESTexecutable:Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.