Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
azeey
reviewed
Dec 14, 2021
added 2 commits
December 14, 2021 17:03
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #786 +/- ##
==========================================
+ Coverage 89.53% 89.56% +0.03%
==========================================
Files 76 76
Lines 12585 12603 +18
==========================================
+ Hits 11268 11288 +20
+ Misses 1317 1315 -2
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <nate@openrobotics.org>
azeey
reviewed
Dec 16, 2021
added 2 commits
December 17, 2021 09:42
Signed-off-by: Nate Koenig <nate@openrobotics.org>
azeey
approved these changes
Dec 17, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Koenig nate@openrobotics.org
🎉 New feature
Summary
The SdfGenerator code in Ignition Gazebo has a map that associates URIs to models. In order to use the DOM to generate SDF with model
<include>elements we need a way to set a model's URI and use the URI in theToElementfunction.This PR support setting a model's URI, and updates the ToElement to use the URI. This won't break ABI because the
Model::ToElementhas not been released.Test it
Run the tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge