Merged
Conversation
added 9 commits
December 3, 2021 09:53
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
added 2 commits
December 10, 2021 10:44
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #783 +/- ##
==========================================
+ Coverage 89.31% 89.52% +0.21%
==========================================
Files 76 76
Lines 12495 12577 +82
==========================================
+ Hits 11160 11260 +100
+ Misses 1335 1317 -18
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This is a bit bigger than the other pull requests. I found a bug when I used
InsertElement. I forgot to set the parent element prior to element insertion. This led me to add a newInsertElementfunction that supports auto-setting the parent element on insertion since this seems to be a very common pattern. To make sure this work, I updated a coupleInsertElementfunction calls inparser.ccto use this new function, and similar swap inElement_TEST.cc.This PR also adds
ToElementfunction toGui,Scene,Sky,andWorld. This should be the last PR related toToElement.Test it
Run the tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge