Skip to content

Model actor toelement functions#782

Merged
nkoenig merged 3 commits intosdf12from
model_actor_toelement
Dec 10, 2021
Merged

Model actor toelement functions#782
nkoenig merged 3 commits intosdf12from
model_actor_toelement

Conversation

@nkoenig
Copy link
Copy Markdown
Contributor

@nkoenig nkoenig commented Dec 10, 2021

🎉 New feature

Summary

Adds ToElement functions for Model and `Actor.

Test it

Run the tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Nate Koenig added 3 commits December 9, 2021 17:30
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Dec 10, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #782 (0aea6a4) into sdf12 (5b48e41) will decrease coverage by 0.01%.
The diff coverage is 82.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf12     #782      +/-   ##
==========================================
- Coverage   89.32%   89.31%   -0.02%     
==========================================
  Files          76       76              
  Lines       12415    12495      +80     
==========================================
+ Hits        11090    11160      +70     
- Misses       1325     1335      +10     
Impacted Files Coverage Δ
src/Model.cc 89.56% <80.00%> (-0.75%) ⬇️
src/Actor.cc 92.73% <83.63%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b48e41...0aea6a4. Read the comment docs.

@nkoenig nkoenig merged commit 2f21fb2 into sdf12 Dec 10, 2021
@nkoenig nkoenig deleted the model_actor_toelement branch December 10, 2021 16:10
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress 🌱 garden Ignition Garden

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants