Merged
Conversation
added 2 commits
December 7, 2021 11:48
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
iche033
reviewed
Dec 7, 2021
Contributor
iche033
left a comment
There was a problem hiding this comment.
looks good to me, just some Windows warnings.
src/Material_TEST.cc
Outdated
| material.SetAmbient(ignition::math::Color(0.1, 0.2, 0.3, 1)); | ||
| material.SetDiffuse(ignition::math::Color(0.4, 0.5, 0.6, 0.5)); | ||
| material.SetSpecular(ignition::math::Color(0.6, 0.4, 0.8, 0.8)); | ||
| material.SetEmissive(ignition::math::Color(0.2, 0.7, 0.9, 0.1)); |
Contributor
There was a problem hiding this comment.
windows warnings for the above 4 lines:
'argument': truncation from 'double' to 'const float'
Signed-off-by: Nate Koenig <nate@openrobotics.org>
iche033
approved these changes
Dec 7, 2021
Codecov Report
@@ Coverage Diff @@
## sdf12 #775 +/- ##
==========================================
- Coverage 89.33% 89.30% -0.03%
==========================================
Files 76 76
Lines 12185 12258 +73
==========================================
+ Hits 10885 10947 +62
- Misses 1300 1311 +11
Continue to review full report at Codecov.
|
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
ToElementforMaterial.Test it
Run the tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge