Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #772 +/- ##
==========================================
+ Coverage 89.23% 89.30% +0.06%
==========================================
Files 76 76
Lines 12081 12160 +79
==========================================
+ Hits 10781 10860 +79
Misses 1300 1300
Continue to review full report at Codecov.
|
iche033
approved these changes
Dec 3, 2021
Member
|
we ran into some questions about the design of DOM objects about a year ago and posted some of them in #292. Here are two of those questions that seem relevant to this work:
cc @azeey |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Koenig nate@openrobotics.org
🎉 New feature
Summary
Adds
ToElementconversions for thePhysicsandAtmosphereDOM objects.Test it
Run the tests
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge