Skip to content

Added ToElement conversion for physics and atmosphere#771

Merged
nkoenig merged 2 commits intosdf12from
physics_atmo_toelement
Dec 6, 2021
Merged

Added ToElement conversion for physics and atmosphere#771
nkoenig merged 2 commits intosdf12from
physics_atmo_toelement

Conversation

@nkoenig
Copy link
Copy Markdown
Contributor

@nkoenig nkoenig commented Dec 3, 2021

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

Adds ToElement conversions for the Physics and Atmosphere DOM objects.

Test it

Run the tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Nate Koenig added 2 commits December 3, 2021 11:10
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Dec 3, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #771 (82bfb74) into sdf12 (3d8147b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf12     #771      +/-   ##
==========================================
+ Coverage   89.23%   89.26%   +0.02%     
==========================================
  Files          76       76              
  Lines       12081    12106      +25     
==========================================
+ Hits        10781    10806      +25     
  Misses       1300     1300              
Impacted Files Coverage Δ
src/Atmosphere.cc 92.72% <100.00%> (+1.23%) ⬆️
src/Physics.cc 85.52% <100.00%> (+4.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8147b...82bfb74. Read the comment docs.

@nkoenig nkoenig merged commit 3b385c9 into sdf12 Dec 6, 2021
@nkoenig nkoenig deleted the physics_atmo_toelement branch December 6, 2021 18:34
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress 🌱 garden Ignition Garden

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants