Skip to content

Prepare for 12.2.0#760

Merged
nkoenig merged 4 commits intosdf12from
12-2-0-prep
Nov 23, 2021
Merged

Prepare for 12.2.0#760
nkoenig merged 4 commits intosdf12from
12-2-0-prep

Conversation

@nkoenig
Copy link
Copy Markdown
Contributor

@nkoenig nkoenig commented Nov 23, 2021

Signed-off-by: Nate Koenig nate@openrobotics.org

🎈 Release

Preparation for 12.2.0 release.

Comparison to 12.1.0: sdformat12_12.1.0...sdf12

Needed by

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release

Note to maintainers: Remember to use Squash-Merge

Prepare for 12.2.0
bd12dbe 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Nov 23, 2021
azeey
azeey approved these changes Nov 23, 2021
View reviewed changes
Changelog.md
* [Pull request #744](https://github.com/ignitionrobotics/sdformat/pull/744)

1. Forward ports
* [Pull request #756](https://github.com/ignitionrobotics/sdformat/pull/756)
Copy link
Copy Markdown
Collaborator

@azeey azeey Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not listing all the PRs from the forward ports anymore?

Copy link
Copy Markdown
Member

@scpeters scpeters Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was a bit of discussion in gazebo-tooling/release-tools#246 but I'm not sure we reached consensus

Copy link
Copy Markdown
Contributor Author

@nkoenig nkoenig Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can list out all of the PRs. I'll get that up soon.

Copy link
Copy Markdown
Contributor Author

@nkoenig nkoenig Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added everything in 50d3ee5.

Nate Koenig and others added 2 commits November 23, 2021 13:48
Updated changelog
50d3ee5 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@scpeters
fix changelog
6c9f225 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #760 (8c9a65f) into sdf12 (8d728ce) will not change coverage.
The diff coverage is n/a.

❗ Current head 8c9a65f differs from pull request most recent head 6c9f225. Consider uploading reports for the commit 6c9f225 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            sdf12     #760   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files          76       76           
  Lines       11905    11905           
=======================================
  Hits        10622    10622           
  Misses       1283     1283

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d728ce...6c9f225. Read the comment docs.

@nkoenig nkoenig merged commit d1b096c into sdf12 Nov 23, 2021
@nkoenig nkoenig deleted the 12-2-0-prep branch November 23, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

@scpeters scpeters scpeters approved these changes

+1 more reviewer

@chapulina chapulina chapulina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🏯 fortress Ignition Fortress 🌱 garden Ignition Garden

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nkoenig @codecov-commenter @azeey @mjcarroll @scpeters @chapulina @j-rivero @osrf-triage