Remove outdated deprecation note from parser_urdf.hh#740
Merged
Conversation
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Member
|
I believe this comment was added in BitBucket pull request 658 and should have been removed in #276 |
azeey
approved these changes
Nov 4, 2021
Collaborator
azeey
left a comment
There was a problem hiding this comment.
Ah, this comment was added when we deprecated /include/sdf/parser_urdf.hh. It should have been removed when the file was moved to src/parser_urdf.hh.
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashton Larkin ashton@openrobotics.org
🦟 Bug fix
Addresses #736 (comment)
Summary
The discussion held in #736 (comment) pointed out that the
URDF2SDFis actually not deprecated and is a private header that is needed, so I have removed the deprecation note from the class' header file.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge