Merged
Conversation
* [sdf6] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * more fixes, new version of script Signed-off-by: Louise Poubel <louise@openrobotics.org>
* [sdf4] Update BitBucket links Signed-off-by: Louise Poubel <louise@openrobotics.org> * fix a few more links Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: chapulina <louise@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Patch popen/pclose method for Windows
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Backport sdf6: Move recursiveSameTypeUniqueNames from ign.cc to parser.cc
* Prepare version 6.3.0 * Add entry in Changelog for 497
* Fix flattening logic for composed names in nested models When nested models use names composed by several elements (i.e: my_model::link) these were not converted by the flattening logic inside parser.cc. The change makes the logic to work with composed names. Added a test to check that this is indeed working as expected. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
) Translate poses of nested models inside other nested models When addNestedModel function is called, it processes links and joints to translate the pose accordingly to parent pose. This was not done for nested models inside the SDF being processed. The change includes nested models in the same way that is doing for links and add a test that fails without the change. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Prepare version 6.3.1 * Implement github actions for sdf6 branch Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* parse rpyOffset as radians Signed-off-by: Ian Chen <ichen@osrfoundation.org> * update tf for xyz and rpy offsets Signed-off-by: Ian Chen <ichen@osrfoundation.org> * remove inverse transform function in urdf parser Signed-off-by: Ian Chen <ichen@osrfoundation.org> * inject corrected_offets tag Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Fix tag removal logic Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
nkoenig
approved these changes
Nov 5, 2021
azeey
requested changes
Nov 5, 2021
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Member
|
I also fixed a compilation error in 331ea53 |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #738 +/- ##
==========================================
+ Coverage 86.82% 87.46% +0.64%
==========================================
Files 63 63
Lines 9897 9893 -4
==========================================
+ Hits 8593 8653 +60
+ Misses 1304 1240 -64
Continue to review full report at Codecov.
|
Contributor
Contributor
Author
azeey
approved these changes
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf6tosdf9Branch comparison: sdf9...sdf6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸