Skip to content

DOC: only allow one canonical_link attribute#716

Merged
azeey merged 4 commits intogazebosim:sdf11from
FirefoxMetzger:fix-canonical-link
Nov 9, 2021
Merged

DOC: only allow one canonical_link attribute#716
azeey merged 4 commits intogazebosim:sdf11from
FirefoxMetzger:fix-canonical-link

Conversation

@FirefoxMetzger
Copy link
Copy Markdown
Contributor

Closes: #703

Changes required="*" to requires="0" for //model/@canonical_link.

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 27, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #716 (064acb6) into sdf11 (8b12338) will not change coverage.
The diff coverage is n/a.

❗ Current head 064acb6 differs from pull request most recent head 9debfb6. Consider uploading reports for the commit 9debfb6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            sdf11     #716   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files          73       73           
  Lines       11014    11014           
=======================================
  Hits         9719     9719           
  Misses       1295     1295           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b12338...9debfb6. Read the comment docs.

@azeey
Copy link
Copy Markdown
Collaborator

azeey commented Nov 8, 2021

I think this can actually go into sdf9. I'll retarget it.

@azeey
Copy link
Copy Markdown
Collaborator

azeey commented Nov 9, 2021

Actually, since this also changes sdf/1.8/model.sdf, we can just backport this to sdf9 once it's merged.

@azeey azeey merged commit 283d4d3 into gazebosim:sdf11 Nov 9, 2021
@FirefoxMetzger FirefoxMetzger deleted the fix-canonical-link branch November 9, 2021 15:48
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏢 edifice Ignition Edifice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

//model should only allow one @canonical_link

7 participants