Conversation
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
azeey
reviewed
Sep 21, 2021
Collaborator
azeey
left a comment
There was a problem hiding this comment.
I think we should also add it to sdf::SDF::PrintValues and sdf::SDF::ToString. The implementation in #689 takes a string for sdf::SDF::PrintValues, but IMO we would be more consistent and have better separation of concerns if it takes sdf::PrintConfig instead. Then the code in ign.cc can parse the command line arguments create the sdf::PrintConfig object and pass it to sdf::SDF::PrintValues().
azeey
reviewed
Sep 21, 2021
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Collaborator
Author
Done 7810a1b |
azeey
approved these changes
Sep 21, 2021
Collaborator
azeey
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick iteration.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added API changes related to
PrintConfigfor #689Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge