Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
|
the code looks fine; we just have to be careful when adding fields to the spec, both when merging forward, and in terms of back porting to do you have a plan for forward and back-porting? |
We currently don't need this in earlier versions but I can backport it if we want to keep the spec consistent? What's the process for merging forward? Should I create separate PRs to add the field to the 1.8 ( |
this would be easier if we kept the spec and parser in separate repositories. we'd probably need to add a patch number to the spec to handle new fields (i.e. 1.6.1). Until then, let's try to keep them consistent
you can copy them over to the new specs in the merge-forward pull request |
|
sounds good, I merge this first and then start porting to other branches. |
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Summary
Add
enable_orientationelement to SDF spec that allows users to configure whether an IMU sensor will generate and output orientation dataChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge