Skip to content

Fix static_cast that triggers compile errors with -Wpedantic (backport #1632)#1641

Merged
iche033 merged 1 commit intosdf15from
mergify/bp/sdf15/pr-1632
Mar 4, 2026
Merged

Fix static_cast that triggers compile errors with -Wpedantic (backport #1632)#1641
iche033 merged 1 commit intosdf15from
mergify/bp/sdf15/pr-1632

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 3, 2026

🦟 Bug fix

Fixes compile errors

Summary

The code does not build with some strict rules such as -Wpedantic due to incorrect casts. This PR fixes the issue.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

This is an automatic backport of pull request #1632 done by Mergify.

@jhanca-robotecai @iche033 @mergify
Fix static_cast that triggers compile errors with -Wpedantic (#1632)
abe1515 
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 645dd54)
@mergify mergify bot requested review from azeey and scpeters as code owners March 3, 2026 23:52
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Mar 3, 2026
@mergify mergify bot mentioned this pull request Mar 3, 2026
Merged
11 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.54%. Comparing base (5ef23de) to head (abe1515).
⚠️ Report is 1 commits behind head on sdf15.

Additional details and impacted files 
@@            Coverage Diff             @@
##           sdf15    #1641       +/-   ##
==========================================
+ Coverage       0   92.54%   +92.54%     
==========================================
  Files          0      139      +139     
  Lines          0    18549    +18549     
==========================================
+ Hits           0    17166    +17166     
- Misses         0     1383     +1383

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Mar 4, 2026
@iche033 iche033 merged commit 085d692 into sdf15 Mar 4, 2026
19 checks passed
@iche033 iche033 deleted the mergify/bp/sdf15/pr-1632 branch March 4, 2026 00:52
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iche033 iche033 iche033 approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

No one assigned

Labels

🏛️ ionic Gazebo Ionic

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iche033 @azeey @jhanca-robotecai