Skip to content

Fix finding urdfdom#1620

Merged
scpeters merged 1 commit intosdf12from
scpeters/fortress_fix_find_urdfdom
Jan 16, 2026
Merged

Fix finding urdfdom#1620
scpeters merged 1 commit intosdf12from
scpeters/fortress_fix_find_urdfdom

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Jan 16, 2026

🦟 Bug fix

Try to fix compiler warnings on jammy

Summary

Add pkg-config to CI package list to see if that helps to find urdfdom.

There are several compiler warnings due to using the internal vendored copy of urdfdom since it fails to find the external copy of urdfdom. I'm guessing that it's failing due to missing pkg-config, so this is a test that addes pkg-config to packages.apt.

Build Status https://build.osrfoundation.org/job/sdformat-ci-sdf12-jammy-amd64/4/

-- Looking for urdfdom - not found
-- Looking for IgnURDFDOM - not found
-- Using internal URDF

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Add pkg-config to CI package list to see if that helps
to find urdfdom.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 16, 2026
@scpeters scpeters marked this pull request as ready for review January 16, 2026 22:28
@scpeters scpeters requested a review from azeey as a code owner January 16, 2026 22:28
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 16, 2026
@scpeters scpeters merged commit 5988687 into sdf12 Jan 16, 2026
14 checks passed
@scpeters scpeters deleted the scpeters/fortress_fix_find_urdfdom branch January 16, 2026 23:29
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants