Skip to content

Disable latex and class hierarchy generation (backport #1447)#1448

Merged
azeey merged 2 commits intosdf9from
mergify/bp/sdf9/pr-1447
Jul 3, 2024
Merged

Disable latex and class hierarchy generation (backport #1447)#1448
azeey merged 2 commits intosdf9from
mergify/bp/sdf9/pr-1447

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jun 28, 2024

Summary

We don't use the latex output anywhere, but it brings in a big dependency when building documentation or deb packages. The class hierarchy is also not that useful since there is not much inheritance used in the codebase. This also brings the doxygen parameters of sdformat closer to other Gazebo libraries.

Note: I plan to Backport this to all the previous versions of sdformat

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #1447 done by Mergify.

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jun 28, 2024

Cherry-pick of 8e7b267 has failed:

On branch mergify/bp/sdf9/pr-1447
Your branch is up to date with 'origin/sdf9'.

You are currently cherry-picking commit 8e7b267b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   doc/sdf.in

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   doc/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from azeey and scpeters as code owners June 28, 2024 21:04
@mergify mergify bot added the conflicts label Jun 28, 2024
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jun 28, 2024
We don't use the latex output anywhere, but it brings in a big
dependency when building documentation or deb packages.
The class hierarchy is also not that useful since there is not much
inheritance used in the codebase. This also brings the doxygen
parameters of sdformat closer to other Gazebo libraries.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
(cherry picked from commit 8e7b267)
@scpeters scpeters force-pushed the mergify/bp/sdf9/pr-1447 branch from 85c6485 to 7dc1854 Compare July 1, 2024 22:20
@scpeters scpeters removed the conflicts label Jul 2, 2024
@azeey azeey merged commit b4a4c84 into sdf9 Jul 3, 2024
@azeey azeey deleted the mergify/bp/sdf9/pr-1447 branch July 3, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants