review feedback

adlarkin · adlarkin · commit fb478e740820 · 2022-03-09T12:18:07.000-07:00
Signed-off-by: Ashton Larkin &lt;42042756+adlarkin@users.noreply.github.com&gt;
diff --git a/usd/src/cmd/usd2sdf.cc b/usd/src/cmd/usd2sdf.cc
@@ -15,11 +15,12 @@
  *
  */
 
-#include <string.h>
+#include <iostream>
+#include <string>
 
 #include <ignition/utils/cli/CLI.hpp>
 
-#include "sdf/sdf.hh"
+#include "sdf/config.hh"
 
 //////////////////////////////////////////////////
 /// \brief Enumeration of available commands
@@ -44,7 +45,8 @@ struct Options
 
 void runCommand(const Options &/*_opt*/)
 {
-  // TODO(ahcorde): Call here the USD to SDF conversor code
+  // TODO(ahcorde): Call here the USD to SDF converter code
+  std::cerr << "USD to SDF conversion is not implemented yet.\n";
 }
 
 void addFlags(CLI::App &_app)
diff --git a/usd/src/usd_parser/usd2sdf_TEST.cc b/usd/src/usd_parser/usd2sdf_TEST.cc
@@ -19,7 +19,6 @@
 #include <gtest/gtest.h>
 
 #include <ignition/common/Filesystem.hh>
-#include <ignition/common/TempDirectory.hh>
 #include <ignition/utilities/ExtraTestMacros.hh>
 
 #include "test_config.h"

Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,12 @@`
`15`	`15`	`*`
`16`	`16`	`*/`
`17`	`17`
`18`		`-#include <string.h>`
	`18`	`+#include <iostream>`
	`19`	`+#include <string>`
`19`	`20`
`20`	`21`	`#include <ignition/utils/cli/CLI.hpp>`
`21`	`22`
`22`		`-#include "sdf/sdf.hh"`
	`23`	`+#include "sdf/config.hh"`
`23`	`24`
`24`	`25`	`//////////////////////////////////////////////////`
`25`	`26`	`/// \brief Enumeration of available commands`
`@@ -44,7 +45,8 @@ struct Options`
`44`	`45`
`45`	`46`	`void runCommand(const Options &/_opt/)`
`46`	`47`	`{`
`47`		`- // TODO(ahcorde): Call here the USD to SDF conversor code`
	`48`	`+ // TODO(ahcorde): Call here the USD to SDF converter code`
	`49`	`+ std::cerr << "USD to SDF conversion is not implemented yet.\n";`
`48`	`50`	`}`
`49`	`51`
`50`	`52`	`void addFlags(CLI::App &_app)`