Conversation
added 4 commits
April 25, 2022 23:51
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde
approved these changes
May 4, 2022
This was referenced May 4, 2022
added 2 commits
May 10, 2022 13:40
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 89.41% 94.36% +4.94%
==========================================
Files 6 7 +1
Lines 189 213 +24
==========================================
+ Hits 169 201 +32
+ Misses 20 12 -8
Continue to review full report at Codecov.
|
ahcorde
requested changes
May 10, 2022
Comment on lines
+82
to
+86
| for vi in range(link.visual_count()): | ||
| col = link.visual_by_index(vi) | ||
| if col.geometry() is not None: | ||
| add_visual(body, col, pose_resolver=pose_resolver) | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| for vi in range(link.visual_count()): | |
| col = link.visual_by_index(vi) | |
| if col.geometry() is not None: | |
| add_visual(body, col, pose_resolver=pose_resolver) | |
| for vi in range(link.visual_count()): | |
| vis = link.visual_by_index(vi) | |
| if vis.geometry() is not None: | |
| add_visual(body, vis, pose_resolver=pose_resolver) | |
added 3 commits
May 10, 2022 16:04
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Collaborator
Author
ahcorde
approved these changes
May 10, 2022
Collaborator
Author
This strategically increases the inertia values in the test and adds an expectation for the exact value of the fullinertia attribute. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Member
Yes, they are based on a box with relative dimensions 1x4x9. I started with the values in this test case but increased the mass by a factor of 32 (12 -> 384) to avoid decimals in the inertial values (aside from |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Builds on top of #2 to add conversion for links.
Test it
Run unit tests
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.