Skip to content

Add simple OccupancyGrid class#685

Merged
azeey merged 25 commits intomainfrom
arjo/feat/occupancy_grid
Aug 22, 2025
Merged

Add simple OccupancyGrid class#685
azeey merged 25 commits intomainfrom
arjo/feat/occupancy_grid

Conversation

@arjo129
Copy link
Copy Markdown
Contributor

@arjo129 arjo129 commented Jun 19, 2025

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

This pull request introduces a C++ library for creating and manipulating occupancy grids. The library includes functionality for calculating information gain and supports Python bindings, making it accessible to a wider range of applications. It was made to support the "export occupancy grid" feature for gz-sim.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Gemini 2.5 Flash, Gemini 2.5 Pro

Generated-by: Gemini 2.5 Flash

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Jun 19, 2025
@arjo129 arjo129 force-pushed the arjo/feat/occupancy_grid branch from 3ad6d3b to 350a344 Compare June 19, 2025 07:55
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to add the Python wrapper ? or if you don't have time to do it please open an issue with the task

Can you add tests too ?

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jun 19, 2025
@arjo129 arjo129 changed the title Working on adding simple occupancy grid class [WIP] Working on adding simple occupancy grid class Jun 19, 2025
@arjo129
Copy link
Copy Markdown
Contributor Author

arjo129 commented Jun 19, 2025

I'll add a python wrapper. Currently this is WIP for visibility.

arjo129 added 3 commits June 20, 2025 04:55
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
This doesn;t make sens for generic occupancy grids, but if people are
interested in generic occupancy grids then they should explore using
NAV2.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@azeey azeey added this to the Jetty Release milestone Jul 28, 2025
@azeey
Copy link
Copy Markdown
Contributor

azeey commented Aug 1, 2025

Hi @arjo129, I've added this to the Jetty Release milestone, but I wasn't sure if you plan to work on it anytime soon. If now, please feel free to remove it from the milestone.

@arjo129
Copy link
Copy Markdown
Contributor Author

arjo129 commented Aug 1, 2025

It'll make jetty.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 self-assigned this Aug 6, 2025
@arjo129 arjo129 moved this from In review to In progress in Core development Aug 6, 2025
arjo129 and others added 6 commits August 19, 2025 06:19
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Generated-by: Gemini-2.5-pro

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 marked this pull request as ready for review August 19, 2025 07:54
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@scpeters scpeters changed the title [WIP] Working on adding simple occupancy grid class Add simple OccupancyGrid class Aug 19, 2025
@scpeters
Copy link
Copy Markdown
Member

since you marked this ready for review, I've removed [WIP] from the title and rephrased slightly

@arjo129 arjo129 requested a review from ahcorde August 20, 2025 14:18
@github-project-automation github-project-automation bot moved this from In progress to In review in Core development Aug 20, 2025
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 requested a review from ahcorde August 21, 2025 05:03
Copy link
Copy Markdown
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. Will continue tomorrow

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 requested a review from azeey August 21, 2025 14:36
Addisu Z. Taddese added 2 commits August 22, 2025 11:31
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Copy link
Copy Markdown
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some style changes in feb7b46 and c08e634

Otherwise, LGTM!

@azeey azeey enabled auto-merge (squash) August 22, 2025 16:41
@azeey azeey merged commit ec99850 into main Aug 22, 2025
12 checks passed
@azeey azeey deleted the arjo/feat/occupancy_grid branch August 22, 2025 16:55
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants