Conversation
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
| LOCAL = 4, | ||
|
|
||
| /// \brief Heading-adjusted tangent plane (X, Y, Z) | ||
| LOCAL2 = 5 |
There was a problem hiding this comment.
there's a GZ_UTILS_WARN_IGNORE__DEPRECATED_DECLARATION macro earlier in this file. Can that be removed?
There was a problem hiding this comment.
Thanks! I commented out it in the same way it is GZ_UTILS_WARN_RESUME__DEPRECATED_DECLARATION just in case it's useful in the future. d7997c4
peci1
left a comment
There was a problem hiding this comment.
Great job! It seems to me all things related to SphericalCoordinates are done properly.
Just a little note, SphericalCoordinates_TEST.py now contains unneeded function ignore_deprecation_warnings. It could be removed.
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Thanks for taking a look! Function removed in 1fb1410. |
🦟 Bug fix
Perform the tock of the tick-tock cycle and remove / move deprecated code.
@peci1
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.