Merged
Conversation
Unifies building steps for unix and win using cmake. Signed-off-by: Alessandro Sofia <al.sofia@studenti.unina.it>
Update to build it from windows Signed-off-by: Alessandro Sofia <al.sofia@studenti.unina.it>
azeey
reviewed
Aug 30, 2024
Contributor
azeey
left a comment
There was a problem hiding this comment.
Thanks. Just a small suggestion to use modern CMake for linking libraries.
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Alessandro Sofia <al.sofia@studenti.unina.it>
Contributor
Author
|
Thank you for the suggestion, I was following the style of the other tutorial, should it be changed also there? |
Contributor
Yeah, I think we should change that as well |
ahcorde
previously requested changes
Sep 2, 2024
azeey
reviewed
Aug 1, 2025
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐢 Tutorial Update
Related to #1362
Summary
Unifies building steps for unix and win using cmake instead of pkg-config.