Check for 0 stddev when generating a random number using normal distribution#615
Merged
Check for 0 stddev when generating a random number using normal distribution#615
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-math7 #615 +/- ##
============================================
- Coverage 94.11% 93.98% -0.14%
============================================
Files 146 149 +3
Lines 9809 9956 +147
============================================
+ Hits 9232 9357 +125
- Misses 577 599 +22 ☔ View full report in Codecov by Sentry. |
azeey
requested changes
Aug 6, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
azeey
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gz-sim#2519
Summary
We use std::normal_distribution in our Rand class. From the doc:
So added a check for 0 stddev (sigma) and return mean if its 0.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.