Skip to content

Fix flaky Stopwatch test#610

Merged
scpeters merged 1 commit intogazebosim:mainfrom
azeey:fix_stopwatch_flake
Jul 17, 2024
Merged

Fix flaky Stopwatch test#610
scpeters merged 1 commit intogazebosim:mainfrom
azeey:fix_stopwatch_flake

Conversation

@azeey
Copy link
Copy Markdown
Contributor

@azeey azeey commented Jul 17, 2024

🦟 Bug fix

Summary

Adds a small sleep between starting the timer and querying the elapsed time to avoid flakiness.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 17, 2024
@scpeters scpeters merged commit 0925141 into gazebosim:main Jul 17, 2024
@azeey azeey deleted the fix_stopwatch_flake branch July 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants