Find python directly instead of using GzPython#588
Merged
Conversation
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
29 tasks
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
j-rivero
approved these changes
May 6, 2024
Contributor
j-rivero
left a comment
There was a problem hiding this comment.
Codecov is complaining about a rate limit:
Rate limit reached. Please upload with the Codecov repository upload token to resolve issue.
Otherwise, code changes looks good to me.
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebosim/gz-cmake#350.
Summary
I suggested in gazebosim/gz-cmake#350 (comment) that we find python directly so that GzPython can be deprecated, and this is a step towards that goal.
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.