Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-math7 #581 +/- ##
============================================
- Coverage 94.11% 94.11% -0.01%
============================================
Files 146 146
Lines 9809 9804 -5
============================================
- Hits 9232 9227 -5
Misses 577 577 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
@scpeters This is ready for review. |
package.xml
Outdated
| <name>gz-math7</name> | ||
| <version>7.4.0</version> | ||
| <description>Gazebo Math : Math classes and functions for robot applications</description> | ||
| <maintainer email="natekoenig@gmail.com">Nate Koenig</maintainer> |
There was a problem hiding this comment.
@adityapande-1995 and I are listed as the CODEOWNERS
There was a problem hiding this comment.
I copied this from the README. Should we update that as well?
There was a problem hiding this comment.
yeah, let's update the README as well
There was a problem hiding this comment.
I guess we list maintainers in the README of other packages
There was a problem hiding this comment.
so yes, let's update the readme as well
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
🎉 New feature
Summary
Add
package.xmlbased on dependencies found in.github/ci/packages.This is to test out using vendor packages to provide Gazebo packages to ROS users (see gazebo-tooling/release-tools#1117).
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.