Skip to content

Fixes for testing in non standard architectures#546

Merged
mjcarroll merged 4 commits intoign-math6from
jrivero/non_arch_fixes_for_test
Aug 22, 2023
Merged

Fixes for testing in non standard architectures#546
mjcarroll merged 4 commits intoign-math6from
jrivero/non_arch_fixes_for_test

Conversation

@j-rivero
Copy link
Copy Markdown
Contributor

@j-rivero j-rivero commented Aug 11, 2023

🦟 Bug fix

Summary

Fixes for tests in non x32 arches:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Jose Luis Rivero added 2 commits August 11, 2023 13:26
Handle non i386/amd4 arches in PI precission
1ba0969 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Avoid to use zero as some arches return negative zero in str
eed29f9 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Aug 11, 2023
@j-rivero j-rivero changed the title jrivero/non arch fixes for test Fixes for testing in non standard architectures Aug 11, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Merging #546 (2187d38) into ign-math6 (469540c) will not change coverage.
The diff coverage is n/a.

❗ Current head 2187d38 differs from pull request most recent head c83702c. Consider uploading reports for the commit c83702c to get more accurate results

@@            Coverage Diff             @@
##           ign-math6     #546   +/-   ##
==========================================
  Coverage      99.38%   99.38%           
==========================================
  Files             75       75           
  Lines           7029     7029           
==========================================
  Hits            6986     6986           
  Misses            43       43

Michael Carroll and others added 2 commits August 22, 2023 07:59
Merge branch 'ign-math6' into jrivero/non_arch_fixes_for_test
90fd982
Fix preprocessor check
c83702c 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll merged commit a0c9148 into ign-math6 Aug 22, 2023
@mjcarroll mjcarroll deleted the jrivero/non_arch_fixes_for_test branch August 22, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@scpeters scpeters scpeters approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-rivero @mjcarroll @scpeters