Skip to content

Forward port 6 to 7, 2023-03-14#526

Merged
nkoenig merged 2 commits intogz-math7from
nkoenig/6-to-7-20230314
Mar 14, 2023
Merged

Forward port 6 to 7, 2023-03-14#526
nkoenig merged 2 commits intogz-math7from
nkoenig/6-to-7-20230314

Conversation

@nkoenig
Copy link
Copy Markdown
Contributor

@nkoenig nkoenig commented Mar 14, 2023

➡️ Forward port

Port ign-math6 to gz-math7

Branch comparison: gz-math7...ign-math6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

nkoenig added 2 commits March 14, 2023 11:29
* Custom PID error rate

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* added test

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

---------

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Mar 14, 2023
Copy link
Copy Markdown
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI !

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2023

Codecov Report

Merging #526 (3946c6f) into gz-math7 (1e84669) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3946c6f differs from pull request most recent head 29cbcb4. Consider uploading reports for the commit 29cbcb4 to get more accurate results

@@            Coverage Diff            @@
##           gz-math7     #526   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7026     7031    +5     
=========================================
+ Hits           7005     7010    +5     
  Misses           21       21           
Impacted Files Coverage Δ
src/PID.cc 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkoenig nkoenig merged commit 85de00b into gz-math7 Mar 14, 2023
@nkoenig nkoenig deleted the nkoenig/6-to-7-20230314 branch March 14, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants