Getting started tutorial: add compiler command#501
Merged
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
2 tasks
Codecov Report
@@ Coverage Diff @@
## gz-math7 #501 +/- ##
=========================================
Coverage 99.70% 99.70%
=========================================
Files 77 77
Lines 7007 7007
=========================================
Hits 6986 6986
Misses 21 21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Sep 14, 2022
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
LGTM, just a minor thing
Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of gazebosim/garden-tutorial-party#194
Summary
The cppgetstarted tutorial has an example program but no instructions to compile it. I've proposed a 1-line UNIX command to compile the program using c-flags from pkg-config.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.