Skip to content

Fixed quaternion from euler example#494

Merged
mjcarroll merged 4 commits intogz-math7from
ahcorde/fix/quaterion_example
Sep 13, 2022
Merged

Fixed quaternion from euler example#494
mjcarroll merged 4 commits intogz-math7from
ahcorde/fix/quaterion_example

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Sep 5, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Fixed quaternion from euler example. Values are already in radians.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2022

Codecov Report

Merging #494 (c986351) into gz-math7 (b9d69e5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           gz-math7     #494   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde requested a review from mjcarroll September 13, 2022 11:20
@mjcarroll mjcarroll merged commit a25610d into gz-math7 Sep 13, 2022
@mjcarroll mjcarroll deleted the ahcorde/fix/quaterion_example branch September 13, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants