Skip to content

🌱🥳: Fixes to tutorials#492

Merged
adityapande-1995 merged 3 commits intogz-math7from
chapulina/7/party/vector
Sep 2, 2022
Merged

🌱🥳: Fixes to tutorials#492
adityapande-1995 merged 3 commits intogz-math7from
chapulina/7/party/vector

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

🦟 Bug fix

Summary

A few fixes to the vector tutorial, while testing binaries on Ubuntu Focal, and went ahead and fixed other places too

  • Clone correct branch
  • I initially didn't have the Ruby bindings installed, so I think it's helpful to explicitly tell how to install them

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the documentation Improvements or additions to documentation label Sep 2, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 2, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2022

Codecov Report

Merging #492 (07b736f) into gz-math7 (0f16476) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           gz-math7     #492   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adityapande-1995 adityapande-1995 merged commit cc9f5de into gz-math7 Sep 2, 2022
@adityapande-1995 adityapande-1995 deleted the chapulina/7/party/vector branch September 2, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation 🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants