Skip to content

VolumetricGridLookupField: generalize index type, add constructor #475

Merged
arjo129 merged 5 commits intomainfrom
arjo/feat/volumetric_grid_custom_constructor
Jul 28, 2022
Merged

VolumetricGridLookupField: generalize index type, add constructor #475
arjo129 merged 5 commits intomainfrom
arjo/feat/volumetric_grid_custom_constructor

Conversation

@arjo129
Copy link
Copy Markdown
Contributor

@arjo129 arjo129 commented Jul 27, 2022

This PR generifies the index term. It also adds a constructor which is used by #456.

Signed-off-by: Arjo Chakravarty arjo@openrobotics.org

arjo129 added 2 commits July 27, 2022 13:31
This PR generifies the index term. It also adds a constructor which is used by #456.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 27, 2022
@arjo129 arjo129 mentioned this pull request Jul 27, 2022
9 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 27, 2022

Codecov Report

Merging #475 (dee59e4) into main (155059b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          75       75           
  Lines        6863     6888   +25     
=======================================
+ Hits         6842     6867   +25     
  Misses         21       21           
Impacted Files Coverage Δ
include/gz/math/VolumetricGridLookupField.hh 96.38% <100.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155059b...dee59e4. Read the comment docs.

Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are minor, LGTM

@chapulina chapulina added the enhancement New feature or request label Jul 27, 2022
@scpeters scpeters changed the title Generify index and adds a new constructor VolumetricGridLookupField: generalize index type, add constructor Jul 28, 2022
arjo129 added 2 commits July 28, 2022 10:31
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
….com:gazebosim/gz-math into arjo/feat/volumetric_grid_custom_constructor
@arjo129 arjo129 enabled auto-merge July 28, 2022 02:55
@arjo129 arjo129 merged commit 3e7f04b into main Jul 28, 2022
@arjo129 arjo129 deleted the arjo/feat/volumetric_grid_custom_constructor branch July 28, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request 🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants