Skip to content

Add addition operator to Matrix6#469

Merged
chapulina merged 3 commits intoign-math6from
chapulina/6/mat6_plus
Jul 21, 2022
Merged

Add addition operator to Matrix6#469
chapulina merged 3 commits intoign-math6from
chapulina/6/mat6_plus

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

@chapulina chapulina commented Jul 20, 2022 •
edited
Loading

🎉 New feature

Summary

I had missed the most important API - the added mass has to be added!

Test it

See the added tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Add addition operator to Matrix6
728c4a7 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jul 20, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 20, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #469 (026c09e) into ign-math6 (88ee511) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 026c09e differs from pull request most recent head a9add9e. Consider uploading reports for the commit a9add9e to get more accurate results

@@            Coverage Diff             @@
##           ign-math6     #469   +/-   ##
==========================================
  Coverage      99.68%   99.68%           
==========================================
  Files             73       73           
  Lines           6901     6913   +12     
==========================================
+ Hits            6879     6891   +12     
  Misses            22       22
Impacted Files Coverage Δ
include/ignition/math/Matrix6.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ee511...a9add9e. Read the comment docs.

ahcorde
ahcorde previously requested changes Jul 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions here #470

  • You can merge them here
  • we can merge this PR and then retarget the other one

ahcorde and others added 2 commits July 21, 2022 14:18
@ahcorde
Suggestion to 469 (#470)
d049d72 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina
Test coverage
a9add9e 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina dismissed ahcorde’s stale review July 21, 2022 21:27

Thanks, merged!

@chapulina chapulina enabled auto-merge (squash) July 21, 2022 21:27
@chapulina chapulina merged commit 6fbc966 into ign-math6 Jul 21, 2022
@chapulina chapulina deleted the chapulina/6/mat6_plus branch July 21, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

@ahcorde ahcorde ahcorde left review comments

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chapulina @ahcorde @scpeters @osrf-triage