ign -> gz Tick-tock Python Libs : gz-math#466
Merged
methylDragon merged 1 commit intomainfrom Jul 15, 2022
Merged
Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 74 74
Lines 6845 6845
=======================================
Hits 6824 6824
Misses 21 21 Continue to review full report at Codecov.
|
Closed
32 tasks
Contributor
Author
|
Build is unstable because of deprecation warnings, not test failures, which this fixes! |
adityapande-1995
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of overarching: gazebo-tooling/release-tools#698
Follow-up to: gazebo-tooling/release-tools#765
In gazebo-tooling/release-tools#765, gz-math Python bindings were tick-tocked to allow use of
ignitionandgz. But the symlinks that are being created on the debbuilder are malformed, even though local builds work fine...This PR fixes that by abusing relative links (it breaks on absolute links for some reason.)
Compare the built
.debfrom this../../../../usr/lib/XXX, when it should be../../../../../usr/lib/XXX)../gz/XXX)Test downstream build using fixed debbuild:
Build is unstable because of deprecation warnings, not test failures, which this fixes!