Skip to content

SphericalCoordinates: make query methods const#452

Merged
adityapande-1995 merged 1 commit intomainfrom
aditya/const_methods
Jul 5, 2022
Merged

SphericalCoordinates: make query methods const#452
adityapande-1995 merged 1 commit intomainfrom
aditya/const_methods

Conversation

@adityapande-1995
Copy link
Copy Markdown
Contributor

@adityapande-1995 adityapande-1995 commented Jul 5, 2022 •
edited
Loading

Signed-off-by: Aditya aditya050995@gmail.com

🦟 Bug fix

Summary

This PR changes SurfaceRadius, AxisEquatorial, AxisPolar, Flattening methods to const, similar to other existing methods Heading(), LatitudeReference(), etc.

Also adds comments to exclude deprecated distance function from code coverage.

Follow up to #434

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@adityapande-1995
Make query methods const
f940826 
Signed-off-by: Aditya <aditya050995@gmail.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 5, 2022
@adityapande-1995 adityapande-1995 changed the title Make query methods const Make spherical coord query methods const Jul 5, 2022
@adityapande-1995 adityapande-1995 requested a review from jennuine July 5, 2022 21:17
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 5, 2022 •
edited
Loading

Codecov Report

Merging #452 (bb46c61) into main (33a4827) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head bb46c61 differs from pull request most recent head f940826. Consider uploading reports for the commit f940826 to get more accurate results

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   99.65%   99.68%   +0.03%     
==========================================
  Files          73       73              
  Lines        6641     6639       -2     
==========================================
  Hits         6618     6618              
+ Misses         23       21       -2
Impacted Files Coverage Δ
src/SphericalCoordinates.cc 99.68% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a4827...f940826. Read the comment docs.

@scpeters scpeters changed the title Make spherical coord query methods const SphericalCoordinates: make query methods const Jul 5, 2022
@adityapande-1995 adityapande-1995 merged commit 3827f4c into main Jul 5, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/const_methods branch July 5, 2022 22:16
This was referenced Jul 6, 2022
Merged
Merged
This was referenced Jul 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

@jennuine jennuine Awaiting requested review from jennuine

Assignees

No one assigned

Labels

🌱 garden Ignition Garden

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityapande-1995 @scpeters @osrf-triage