Skip to content

Add Aditya as codeowner#440

Merged
adityapande-1995 merged 1 commit intomainfrom
aditya/add_code_owner
Jun 10, 2022
Merged

Add Aditya as codeowner#440
adityapande-1995 merged 1 commit intomainfrom
aditya/add_code_owner

Conversation

@adityapande-1995
Copy link
Copy Markdown
Contributor

@adityapande-1995 adityapande-1995 commented Jun 10, 2022

Signed-off-by: Aditya aditya050995@gmail.com

.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Summary

Add myself as a codeowner.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@adityapande-1995
Updated codeowners
056d144 
Signed-off-by: Aditya <aditya050995@gmail.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 10, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #440 (056d144) into main (2bde663) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          73       73           
  Lines        6588     6588           
=======================================
  Hits         6568     6568           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bde663...056d144. Read the comment docs.

@scpeters scpeters changed the title Updated codeowners Add Aditya as codeowner Jun 10, 2022
@adityapande-1995 adityapande-1995 merged commit 3441c1d into main Jun 10, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/add_code_owner branch June 10, 2022 21:16
@chapulina
Copy link
Copy Markdown
Contributor

chapulina commented Jun 17, 2022

We should backport this to ign-math6 😉

@adityapande-1995 adityapande-1995 mentioned this pull request Jun 20, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

Assignees

No one assigned

Labels

🌱 garden Ignition Garden

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapande-1995 @chapulina @scpeters @osrf-triage