Merged
Conversation
Part of #60. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Jun 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 73 73
Lines 6588 6588
=======================================
Hits 6568 6568
Misses 20 20
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #60.
Summary
As noted in gz-math#60, there are concerns about the pose subtraction operator. Given that it is equivalent to multiplying by an inverse (albeit with reversed order
A - B = B.Inverse() * A), this deprecates the unitary negation operator-and the subtraction operators-and-=.This is a draft PR until all usage of the deprecated behavior has been replaced in downstream repositories.
Test it
Run
UNIT_Pose3_TESTChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.