Skip to content

Update GoogleTest to latest version#435

Merged
mjcarroll merged 8 commits intomainfrom
bump_gtest
Jun 28, 2022
Merged

Update GoogleTest to latest version#435
mjcarroll merged 8 commits intomainfrom
bump_gtest

Conversation

@mjcarroll
Copy link
Copy Markdown

@mjcarroll mjcarroll commented May 31, 2022 •
edited
Loading

Import latest version of GoogleTest from upstream and adjust build accordingly.

Signed-off-by: Michael Carroll michael@openrobotics.org

@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 31, 2022
@mjcarroll mjcarroll marked this pull request as ready for review May 31, 2022 15:37
@mjcarroll mjcarroll requested a review from scpeters as a code owner May 31, 2022 15:37
@codecov
Copy link
Copy Markdown

codecov bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #435 (68fc596) into main (0919a13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          73       73           
  Lines        6567     6567           
=======================================
  Hits         6547     6547           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0919a13...68fc596. Read the comment docs.

@mjcarroll
Copy link
Copy Markdown
Author

mjcarroll commented May 31, 2022

I'm going to hold off and see if there are any more changes uncovered when doing the other libraries.

@chapulina
Copy link
Copy Markdown
Contributor

chapulina commented Jun 8, 2022

Would it be possible to target this at ign-math6? I'm working on some tests that only pass with these changes 😬

@mjcarroll
Copy link
Copy Markdown
Author

mjcarroll commented Jun 8, 2022

I'm working on some tests that only pass with these changes.

Likely yes, but what kind of tests out of curiosity?

Michael Carroll added 4 commits June 27, 2022 13:27
Remove old gtest version
cb76374 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Add new vendored Googletest version
3bdbf1f 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Move test_config H to HH
ae3c075 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
CMake updates for new googletest version
621dfb2 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll mentioned this pull request Jun 28, 2022
Closed
14 tasks
Test updates for new googletest version
31ffca0 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Michael Carroll added 3 commits June 27, 2022 22:04
Remove all gtest_main functions
f3baa3c 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Merge branch 'main' into bump_gtest
29677de
Explicitly export c++17 where required
68fc596 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit d15c9b2 into main Jun 28, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 28, 2022 21:31
@srmainwaring srmainwaring mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees

No one assigned

Labels

🌱 garden Ignition Garden

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjcarroll @chapulina @ahcorde @osrf-triage