Skip to content

Reduce compilation time#433

Merged
scpeters merged 5 commits intomainfrom
compile_faster
Jun 13, 2022
Merged

Reduce compilation time#433
scpeters merged 5 commits intomainfrom
compile_faster

Conversation

@mjcarroll
Copy link
Copy Markdown

@mjcarroll mjcarroll commented May 26, 2022 •
edited
Loading

Noticed that math seemed really slow. Quick look and it seems like we were overusing inline in the Helpers.hh file.

Between moving some of the inlined functions and pruning unneeded headers, we pick up about 30 seconds on my system.

Before:

**** Time summary:
Compilation (165 times):
  Parsing (frontend):           94.3 s
  Codegen & opts (backend):     62.3 s

After:

**** Time summary:
Compilation (165 times):
  Parsing (frontend):           63.9 s
  Codegen & opts (backend):     60.2 s

@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 26, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #433 (aff2741) into main (3441c1d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files          73       73              
  Lines        6588     6567      -21     
==========================================
- Hits         6568     6547      -21     
  Misses         20       20
Impacted Files Coverage Δ
include/gz/math/graph/Graph.hh 100.00% <ø> (ø)
include/gz/math/Helpers.hh 100.00% <100.00%> (ø)
include/gz/math/detail/InterpolationPoint.hh 100.00% <100.00%> (ø)
src/Helpers.cc 98.63% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3441c1d...aff2741. Read the comment docs.

@mjcarroll mjcarroll marked this pull request as ready for review May 27, 2022 00:45
@mjcarroll mjcarroll requested a review from scpeters as a code owner May 27, 2022 00:45
ahcorde
ahcorde requested changes May 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  /github/workspace/include/gz/math/Helpers.hh:588:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]

Remove some inlined helpers for compile time
e50cb5a 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Prune unneeded headers where possible
bb81007 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Michael Carroll added 2 commits June 1, 2022 11:53
Merge branch 'main' into compile_faster
4b19663
ignition -> gz
9a12100 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from ahcorde June 1, 2022 18:24
@scpeters scpeters changed the title Compile faster Reduce compilation time Jun 13, 2022
@scpeters scpeters merged commit a5fa077 into main Jun 13, 2022
@scpeters scpeters deleted the compile_faster branch June 13, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scpeters scpeters scpeters approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees

No one assigned

Labels

🌱 garden Ignition Garden

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mjcarroll @ahcorde @scpeters @chapulina @osrf-triage