ign -> gz Namespace Migration : gz-math#430
Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
3b493fe to
801dc4b
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
6b15d1f to
b421b81
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
left a comment
There was a problem hiding this comment.
LGTM with 🟢 CI, just minor comments
| @@ -1,4 +1,4 @@ | |||
| %module "ignition::math" | |||
| %module "gz::math" | |||
There was a problem hiding this comment.
I don't know if this has packaging consequences, we may need to update the -release repo after this is merged
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
include/gz/math/Material.hh
Outdated
| /// | ||
| /// This class will replace the | ||
| /// [MaterialDensity class](https://github.com/ignitionrobotics/ign-common/blob/ign-common1/include/gz/common/MaterialDensity.hh) | ||
| /// [MaterialDensity class](https://github.com/gazebosim/gz-common/blob/ign-common1/include/gz/common/MaterialDensity.hh) |
There was a problem hiding this comment.
I just noticed this link was previously broken because the include/gz folder doesn't exist on the ign-common1 branch
There was a problem hiding this comment.
Should I point it to main or point gz back to ignition?
There was a problem hiding this comment.
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
left a comment
There was a problem hiding this comment.
Nice! Just pending 🟢 CI
Signed-off-by: methylDragon <methylDragon@gmail.com>
scpeters
left a comment
There was a problem hiding this comment.
I think we shoudn't change the namespace references in the parts of our migration guide that refers to old versions.
I'm also not sure we should change the changelog to refer to old versions (like Gazebo math 2) when we aren't changing that code at all. Are we allowed to historically refer to old versions as ignition, or does it all have to change to gazebo?
having discussed this further offline, I think the changes are fine as is |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 49 49
Lines 4396 4396
=======================================
Hits 4389 4389
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
See gazebo-tooling/release-tools#711